D8388: Do not hardcode unhovered windows brightness on present windows effect
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added a comment. > From KWin side: PresentWindows is actually in change freeze since a long time. The code is fragile and I don't like to see it being changed again. The code is straight forward and I don't think it would cause issue, but I'm looking at the bigger picture here with having blocked changes for years because the code is fragile. That's pretty good argument! Frankly, dimming windows is not really good idea, imho. Adding outline around windows would be much better, imho. On the other hand, as Martin said, the code is fragile. E.g., in some cases, calculateWindowTransformations can bring KWin to knees. Maybe we could come up with something better when we port the Present Windows and the Desktop Grid effect to QML? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8388 To: salvacorts, #kwin, #vdg, #plasma Cc: zzag, graesslin, ngraham, kwin, #kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart