D15372: [effects] Make scripted effect GHNS-able

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  Currently, if one wants to install a scripted effect from the KDE Store,
  the effect won't show up in the Desktop Effects KCM. The reason for that
  is kpackagetool5 doesn't know where to install effects (they have to be
  installed under ${DATA_DIR}/kwin/effects).
  
  Another problem is that even if the scripted effect is installed in the
  right directory (e.g. ~/.local/share/kwin/effects), it won't be listed in
  the Desktop Effects KCM because it doesn't have a desktop file in
  kservices5 dir.
  
  This diff addresses those 2 problems by:
  
  - Adding a PackageStructure plugin for effects (so they are installed under kwin/effects/);
  - Using KPackage::PackageLoader to get list of scripted effect in the Desktop Effects KCM.

TEST PLAN
  - Installed an effect from the KDE Store, it appeared in the Desktop Effects KCM;
  - Removed it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15372

AFFECTED FILES
  kcmkwin/kwincompositing/CMakeLists.txt
  kcmkwin/kwincompositing/model.cpp
  packageplugins/CMakeLists.txt
  packageplugins/effect/CMakeLists.txt
  packageplugins/effect/effect.cpp
  packageplugins/effect/effect.h
  packageplugins/effect/kwin-packagestructure-effect.desktop

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart