D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added a comment. In D15275#323311 <https://phabricator.kde.org/D15275#323311>, @davidedmundson wrote: > As you're doing the common fix for QRect::right/bottom fix would it be cleaner to just use a QRectF for the area and then kill all the +1s? Yes, it would. But then we would mix QRectF's and QRect's. Nah, that's a can of worms. Can we push it as it is right now(this diff pretty much corrects existing calculations) and revisit this in the future? REPOSITORY R108 KWin BRANCH effects-magnifier-fix-1px-gaps REVISION DETAIL https://phabricator.kde.org/D15275 To: zzag, #kwin, davidedmundson Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart