D15234: Remove breaking pointer constraints functionality

hein added a reviewer: VDG.
hein added a comment.


  If I understood things right, prior work made sure that deactivating a client via any means (alt-tab, opening KRunner, etc.) will break a clients' pointer constraint (and hopefully recreate it when the client gets activated again). And this patch removes the previous dedicated means to do so, long-pressing ESC, and the notification informing the user of this possibility.
  
  I'm not sure that's good. "Having" to alt-tab to break a constraint seems a bit awkward to me, like you are asked to apply a work-around to a troublesome situation.
  
  Additionally, I think the two should kind of behave differently perhaps - alt-tab should break the constraint temporarily (until the client is activated again), ESC possibly permanently? Not sure.
  
  I agree the notification/feature is a bit useless for fullscreen clients, though, which are naturally deactivated by quitting or alt-tabbing. I'd restrict it to windowed clients.
  
  This is a UX thing, so the VDG should be involved.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15234

To: romangg, #kwin, #vdg
Cc: hein, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart