D15413: [effects/dialogparent] Fix strict mode issues
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.
REVISION SUMMARY
Modification of undeclared variables is illegal in the strict mode, e.g.
mainWindows = window.mainWindows();
is illegal.
TEST PLAN
The Dialog Parent effect works with both QScriptEngine and QJSEngine.
REPOSITORY
R108 KWin
BRANCH
effects-dialogparent-fix-strict-mode-issues
REVISION DETAIL
https://phabricator.kde.org/D15413
AFFECTED FILES
effects/dialogparent/package/contents/code/main.js
To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart