D14536: [scripting] Port ScriptedEffects to QJSEngine
Fabian Vogt <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
fvogt added inline comments. INLINE COMMENTS > scriptedeffect.cpp:428 > + } > + return ok; > } This always returns true - is that intentional? I assume this should've been `ok &= cancel(...)`. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14536 To: davidedmundson, #kwin, mart, fvogt Cc: fvogt, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart