D14536: [scripting] Port ScriptedEffects to QJSEngine
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson marked 10 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in scriptedeffect.cpp:227 > Should it really be a qCDebug? Maybe qCCritical? The old code was a qcdebug. I remember trying to change it once in the past and I had that change blocked. > fvogt wrote in scriptedeffect.cpp:428 > This always returns true - is that intentional? I assume this should've been `ok &= cancel(...)`. heh, old code quit on first error I'll change to that. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14536 To: davidedmundson, #kwin, mart, fvogt Cc: fvogt, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart