D14536: [scripting] Port ScriptedEffects to QJSEngine

davidedmundson added inline comments.

INLINE COMMENTS

> fvogt wrote in kwineffects.h:2230
> @davidedmundson This might be one of the broken cases - please check

There are two types of role

GrabRole    which should be set to a pointer to the object

For a Scripted effect:

  w.setData(Effect.WindowClosedGrabRole, effect);

resulted in QVariant(QObject*, ScriptedEffectWithDebugSpy(0x7f7f60006190))

which looks fine

The other roles (such as WindowForceBackgroundContrastRole) should be a boolean

  w.setData(Effect.WindowForceBackgroundContrastRole, true);

which resulted in QVariant(bool, true)

which also looks fine

---

Obviously one can do something stupid like setData(["asdfasf", 2]) which results in a QJSValue  but unboxing won't help.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14536

To: davidedmundson, #kwin, mart, fvogt
Cc: fvogt, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart