D15234: Remove breaking pointer constraints functionality
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added a comment. In D15234#323917 <https://phabricator.kde.org/D15234#323917>, @ngraham wrote: > Thanks Roman! I agree that changing focus with alt-tab (or anything else) should disable the pointer lock, that the notification message is annoying and should go, and that "long press esc for 5 seconds" is not very obvious and probably should go too. I find myself agreeing with @hein that pointer lock should return if the client regains focus: if I alt-tab out of my FPS game to check my email, when I alt-tab back, it should work again (provided I haven't been killed during the email break lol). That's already the case. > If we are trying to provide an "emergency escape valve" for poorly programmed apps that don't give up pointer locking when they should, let's consider what people do when they panic in response to an anxiety-producing situation with their computer: > > - Force-shutdown using the physical power key or power cord (not helpful) > - Close the laptop screen (not helpful) > - Quit the app using a keyboard shortcut, if they know one (not helpful) > - Mash the escape key (ahh, now this is helpful!) > > So instead of "long press escape for 5 seconds", how about "press the escape key in quick succession 3 or more times"? There is [Alt+F4] for killing misbehaving clients. Known to most people using a PC and documented in our keyboard shortcut system. In comparision hitting Escape key for several times to do something on the compositor level is not really better than long pressing. The user still would need to be informed about it somehow. We can't assume every user hits repeatedly (and fast enough) Esc when there is something not working. And what if I have to press Esc several times to quickly check a menu in game? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D15234 To: romangg, #kwin, #vdg Cc: ngraham, hein, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart