D15272: [effects/trackmouse] Allow to use both modifiers and shortcut

davidedmundson added inline comments.

INLINE COMMENTS

> trackmouse.cpp:220
> +    switch (m_state) {
> +    case State::ActivatedByModifiers:
> +    case State::ActivatedByShortcut:

One comment I forgot to save.

There's an inbalance here:

If you activate by shortcut, then pressing a modifier on and off won't disable it
But if you activate by modifier then toggling the shortcut will disable it

This might become an issue if a user has it bound to both meta modifier and shortcut meta+a and pressed whilst moving the mouse.

They would hit meta, activate it by modifier, press the shortcut which then turns it off, release the keys and then it would stay off even though they hit the shortcut once.

/maybe/ we actually want

case State::ActivatedByModifiers:

  m_state = ActivatedByShortcut
  break;

but it's an extreme edge case

REPOSITORY
  R108 KWin

BRANCH
  effects-trackmouse-shortcut

REVISION DETAIL
  https://phabricator.kde.org/D15272

To: zzag, #kwin, #plasma, #vdg, davidedmundson
Cc: broulik, abetts, ngraham, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart