D15272: [effects/trackmouse] Allow to use both modifiers and shortcut
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > zzag wrote in trackmouse.cpp:220 > > If you activate by shortcut, then pressing a modifier on and off won't disable it. But if you activate by modifier then toggling the shortcut will disable it > > That's totally intentional. > > > They would hit meta, activate it by modifier, press the shortcut which then turns it off, release the keys and then it would stay off even though they hit the shortcut once. > > mouseChanged is emitted when, for example, mouse has been moved. If you press a modifier key, mouseChanged is not emitted. So, that's fine. > > Also, this leads to a bug in some sense, e.g. if you stop moving mouse and **then** release modifiers, the effect will be still active even though modifiers are not pressed anymore. OK, that's bs. On Wayland, I suppose things are a little bit different. REPOSITORY R108 KWin BRANCH effects-trackmouse-shortcut REVISION DETAIL https://phabricator.kde.org/D15272 To: zzag, #kwin, #plasma, #vdg, davidedmundson Cc: broulik, abetts, ngraham, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart