D14536: [scripting] Port ScriptedEffects to QJSEngine

zzag added a comment.


  In D14536#323772 <https://phabricator.kde.org/D14536#323772>, @davidedmundson wrote:
  
  > My other options I've considered are:
  >
  > - https://paste.kde.org/pfu7nznz6
  
  
  Hmm, really tricky option. :D
  
  > - In Qt replace  if (type == qMetaTypeId<QList<QObject *> >()) {     with  if (QMetaType::hasRegisteredConverterFunction(type, qMetaTypeIdQList<QObject*>>)  in the billion places. Then merge this in 18 months.
  
  18 months because the change would be that big?
  
  > Ultimately libkwineffects has no API or ABI promises so we don't need to create too much of a maintenance burden on ourselves if we don't need to.
  
  Still, it would be nice to keep source-code compatibility. FWIW, there are some third party effects. For example, today when I was browsing reddit, I stumbled upon a C++ effect that rounds corners.
  
  I don't like that we're polluting C++ API just because of scripting. Is it a good idea in long term?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14536

To: davidedmundson, #kwin, mart
Cc: fvogt, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart