D14536: [scripting] Port ScriptedEffects to QJSEngine

davidedmundson added a comment.


  
  
  > 18 months because the change would be that big?
  
  Because it would be Qt 5.13 at the earliest, then we have to wait for us to depend on that version which takes forever.
  
  > 
  > 
  >> Ultimately libkwineffects has no API or ABI promises so we don't need to create too much of a maintenance burden on ourselves if we don't need to.
  > 
  > I don't like that we're polluting C++ API just because of scripting.
  
  It don't exactly like it either, but that doesn't make the other options any better, especially long term.
  
  Right now our options are:
  Using a deprecated module, a monsterous amount of shadowing, tricking Qt's moc, a single change in the C++ API, or alternatively breaking the JS API (it arguably should have been a property anyway)
  
  Given we're not in an urgent rush, we do have the option of deprecating something before dropping.
  
  BTW I can fairly easily move the QList<QObject*> mainWindows() out of EffectWindow  so it's not "polluting", I can put the invokable in EffectWindowImpl or in a class inbetween. 
  But I still need to rename that existing method there.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14536

To: davidedmundson, #kwin, mart
Cc: fvogt, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart