D15473: [effects/fadedesktop] Port to explicit animate API

David Edmundson <[email protected]> Thu, 13 Sep 2018 11:02:49 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in main.js:57
> Should it be 1.0?

This matches the previous code, but arguably yes it should

AnimationEffect::paintWindow

is (correctly) using WindowPaintData::multiplyOpacity not setOpacity

and WindowPaintData::opacity defaults to the window opacity

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15473

To: davidedmundson, #kwin
Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart