D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects

David Edmundson <[email protected]> Thu, 13 Sep 2018 13:00:04 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

davidedmundson updated this revision to Diff 41544.
davidedmundson added a comment.


  Swap the enum tristate for whether any effect is full screen or if we're the active full screen effect
  with 2 booleans.
  
  In hindsight it's easier for scripts to bind to the two of them as applicable as with the enum they need to 
  keep track of what changes are relevant. Best to keep scripting as simple as possible and do more complex logic 
  externally.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14688?vs=41003&id=41544

REVISION DETAIL
  https://phabricator.kde.org/D14688

AFFECTED FILES
  autotests/integration/effects/scripted_effects_test.cpp
  autotests/integration/effects/scripts/fullScreenEffectTest.js
  autotests/integration/effects/scripts/fullScreenEffectTestMulti.js
  libkwineffects/anidata.cpp
  libkwineffects/anidata_p.h
  libkwineffects/kwinanimationeffect.cpp
  libkwineffects/kwinanimationeffect.h
  scripting/scriptedeffect.cpp
  scripting/scriptedeffect.h

To: davidedmundson, #kwin, zzag
Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart