D15480: [wayland] Dismiss popups when they lose focus

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  Currently, if you right-click the desktop and then click somewhere
  else(e.g. panel), the popup will stay visible.
  
  This happens because KWin doesn't dismiss popups if you click somewhere
  else in the same app. The desktop window and the panel window belong to
  the same app so the popup is not dismissed.
  
  From user's perspective this is wrong because the popup lost focus, thus
  it should be dismissed.
  
  testDecoCancelsPopup was deleted because it doesn't really matter
  whether we click on decoration, what matters is whether we click outside
  of popup.
  
  BUG: 379635
  FIXED-IN: 5.14.0

TEST PLAN
  - Right-clicked desktop, then clicked panel (the popup disappeared);
  - Right-clicked empty area in Dolphin, then clicked the "Control" button (the popup disappeared);
  - Right-clicked empty area in Dolphin, then clicked empty area on my desktop (the popup disappeared).

REPOSITORY
  R108 KWin

BRANCH
  wayland-dismiss-popups-on-lost-focus

REVISION DETAIL
  https://phabricator.kde.org/D15480

AFFECTED FILES
  autotests/integration/pointer_input.cpp
  popup_input_filter.cpp

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.