D15135: [wayland] Syncronise pending geometry with acked configure requests

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  > A surface represents the last configure that was acked.
  
  What does this mean in the summary? What surface?

INLINE COMMENTS

> shell_client.cpp:1210
> +        }
> +        auto configureRequest = m_pendingConfigureRequests.takeFirst();
> +        position = configureRequest.positionAfterResize;

Instead of taking always the first one and by that looping through ignore (and remove) all configure events before the one associated with `m_lastAckedConfigureRequest` and only add a layer repaint and so on for `m_lastAckedConfigureRequest`.

> shell_client.h:215
> +    struct PendingConfigureRequest {
> +        //note for wl_shell we have no serial, so it and m_lastAckedConfigureRequest will always be 0
> +        //meaning we treat a surface commit as having processed all requests

minor: to better understand the comment replace `"it"` with `"serialId"`

> shell_client.h:217
> +        //meaning we treat a surface commit as having processed all requests
> +        int serialId = 0;
> +        // position to apply after a resize operation has been completed

quint32

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15135

To: davidedmundson, #kwin, romangg
Cc: romangg, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart