D15175: [effects/cubeslide] Fix several cubeslide issues

zzag added a comment.


  This diff addresses two 2 different problems:
  
  - visual artifacts caused by the blur and the background contrast effect;
  - usage of isManaged for Wayland clients.
  
  Can you please split this patch into two? (all you have to do is just replace `w->isSpecialWindow()` with `!w->isManaged()`, I guess)

INLINE COMMENTS

> cubeslide.cpp:530-532
> +    if (!isActive()) {
> +        return;
> +    }

You don't really need it.

> cubeslide.cpp:545-555
> +        // XXX: We want to always animate OSDs, but only animate ordinary windows if dontSlideStickyWindows is checked
> +        // Apparently, acceptsFocus() is the only way how OSD differs from ordinary window on Wayland
> +        // For X11 the window is marked as special. So it should work
> +        // (borrowed from FlipSwitch::isSelectableWindow())
> +        if (w->isSpecialWindow()) {
> +            return false;
> +        }

After thinking for a while, I think this should be

  if (w->isSpecialWindow()) {
      return false;
  }
  return !dontSlideStickyWindows;

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15175

To: poboiko, #kwin, zzag
Cc: davidedmundson, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart