D15135: [wayland] Syncronise pending geometry with acked configure requests

Roman Gilg <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  It's missing still a cleanup in case the client is broken as in not responding to any configure events or with the wrong serials and the vector would grow limitless. But we can do this in a second patch.

INLINE COMMENTS

> shell_client.cpp:1205
> +    for (auto it = m_pendingConfigureRequests.begin(); it != m_pendingConfigureRequests.end(); it++) {
> +        if (it->serialId > m_lastAckedConfigureRequest) {
> +            break;

Instead of checking on every iteration, just check against the first element of the vector before looping since the serials are monotonically increasing.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15135

To: davidedmundson, #kwin, romangg
Cc: romangg, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.