D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added a comment. > Frankly, I prefer the old approach (with tristate). Now, we have two very similar properties. I found doing the fadedesktop changes (and using the API) I needed quite a bit of boiler plate involving an ugly global var to turn it into anything usable. a signal fullScreenEffectStateChanged(newState, oldState) would have sufficed, but then it doesn't nicely map to property notifications and it still leaves tedious logic in the JS code. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14688 To: davidedmundson, #kwin, zzag Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart