D15150: [wayland] Asyncronously update maximise flags
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg accepted this revision.
romangg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> shell_client.cpp:836
> if (!adjust) {
> if (vertical)
> + m_requestedMaximizeMode = MaximizeMode(m_requestedMaximizeMode ^ MaximizeVertical);
Improve coding style when you are at it.
> shell_client.h:226
> +
> + //mode in use by the current buffer
> + MaximizeMode m_maximizeMode = MaximizeRestore;
Why did you move these lines from below up here? I would leave them where m_mximizeMode was before. But it's not important. You can push as is as well.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D15150
To: davidedmundson, #kwin, romangg
Cc: romangg, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart