D15626: [effects/slidingpopups] Fix jumpy transition between In and Out animations

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  If a window is being slided in and for some reason it gets closed, the
  window will be slided out. The problem is a jump between the slide in
  animation and the slide out animation.
  
  The reason for that is we cancel the slide in animation when the slide
  out animation is started.
  
  That cancelation had been made on purpose because the in and out
  animation are different(they have different duration). But visually, it
  doesn't look good.
  
  TimeLine tries to preserve progress value when changing duration. Thus,
  let's utilize that to fix the jump.
  
  This change matters only with animation speed factor > 1.0.
  
  CCBUG: 264276

TEST PLAN
  Manually.

REPOSITORY
  R108 KWin

BRANCH
  effects-slidingpopups-smooth-slide-in-out

REVISION DETAIL
  https://phabricator.kde.org/D15626

AFFECTED FILES
  effects/slidingpopups/slidingpopups.cpp

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart