D15634: [WobblyWindows] Prevent hash table to grow significantly

zzag added a comment.


  When you start to experience lags in the Wobbly Windows effects, can you please run
  
    qdbus org.kde.KWin /KWin supportInformation
  
  and post the output here.
  
  ---
  
  Regarding the subject line, KWin follows different style for that. It should be "[effects/wobblywindows] Blah-blah", please stick with that.
  
  Regarding the commit message, it would be great to have a thorough analysis, e.g. does the amount of used memory grow over time, is the wobbly windows effect active all the time (i.e. it doesn't clean up after itself), describe how you use the effect, what does the qCDebug in the destructor says, profile KWin (e.g. with hotspot), etc.
  
  In D15634#329241 <https://phabricator.kde.org/D15634#329241>, @broulik wrote:
  
  > There's a conditional on `m_closeEffectEnabled` so maybe in some circumstance it is indeed missed. I don't know the architecture enough to judge whether doing unconditionally doing it in `windowDeleted` is a proper fix
  
  
  It's `false` by default. So, I think that shouldn't be a problem. (also, maybe it would be better to drop OpenEffect and CloseEffect, but that's off topic)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15634

To: anthonyfieroni, #kwin, zzag
Cc: broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart