D15695: [effects/snaphelper] Do massive overhaul

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  This patch fixes some of issues that the Snap Helper effect currently
  has:
  
  - If a window is being moved, there are visual artifacts (cause: missing addRepaint's);
  - It uses addRepaintFull;
  - For some reason, if a window goes deleted, it will be kept around as long as the Snap Helper effect needs it (visually, it doesn't look good).
  
  Among other changes:
  
  - Use variables to store color and width of grid lines;
  - Use new connect syntax;
  - Port to TimeLine;
  - Fix coding style in some places.

TEST PLAN
  Tried the effect with different rendering backends, no longer see visual
  artifacts when moving or resizing windows.

REPOSITORY
  R108 KWin

BRANCH
  effects-snaphelper-massive-overhaul

REVISION DETAIL
  https://phabricator.kde.org/D15695

AFFECTED FILES
  effects/snaphelper/snaphelper.cpp
  effects/snaphelper/snaphelper.h

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart