D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added a comment.


  In D14688#325475 <https://phabricator.kde.org/D14688#325475>, @davidedmundson wrote:
  
  > I found doing the fadedesktop changes (and using the API) I needed quite a bit of boiler plate involving an ugly global var to turn it into anything usable.
  >  a signal fullScreenEffectStateChanged(newState, oldState) would have sufficed, but then it doesn't nicely map to property notifications and it still leaves tedious logic in the JS code.
  
  
  Can fullScreenEffectActive belong then to `effects`?
  
  effects.fullScreenEffectActive : any effect is full screen
  effect.fullScreenEffectActive : "local" to the effect, maybe the name is not the best

INLINE COMMENTS

> scriptedeffect.h:41
>      Q_ENUMS(EasingCurve)
> +    Q_ENUMS(ActiveFullScreenEffectState)
> +    // Whether any full screen effect is running

Leftover.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14688

To: davidedmundson, #kwin, zzag
Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.