D15703: [effects/showpaint] Use a shortcut to toggle the effect

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  The Show Paint effect is useful when debugging repaint regions issued by
  effects. The only headache with it is necessity to enable/disable it.
  Consider the following workflow:
  
  - Do some change to an effect;
  - Compile KWin (or the effect);
  - Go to System Settings and enable the Show Paint effect;
  - Test effect, check repaint regions, etc;
  - Disable the Show Paint effect;
  - Go to the step 1.
  
  This workflow is really exhausting. Also, when testing repaints in a
  nested compositor, things become quite messy.
  
  Because purpose of this effect is to debug repaints (and because this
  effect is not meant for daily usage), I think that's fine to change
  how it's activated.
  
  This patch improves previously mentioned workflow by changing the way
  how this effect gets activated. Instead of enabling/disabling it, one
  can just use a shortcut to activate or deactivate the effect.

REPOSITORY
  R108 KWin

BRANCH
  effects-showpaint-shortcut

REVISION DETAIL
  https://phabricator.kde.org/D15703

AFFECTED FILES
  effects/CMakeLists.txt
  effects/showpaint/CMakeLists.txt
  effects/showpaint/showpaint.cpp
  effects/showpaint/showpaint.h
  effects/showpaint/showpaint_config.cpp
  effects/showpaint/showpaint_config.desktop
  effects/showpaint/showpaint_config.h
  effects/showpaint/showpaint_config.ui

To: zzag, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart