D15707: [effects/slide] Simplify logic that forces blur and background contrast

davidedmundson added a comment.


  > The "Force" part in WindowForceBackgroundContrastRole and WindowForceBlurRole
  
  is confusing.
  
  It really is.
  
  I don't understand why we still do
  
    if ((scaled || (translated || (mask & PAINT_WINDOW_TRANSFORMED))) && !w->data(WindowForceBlurRole).toBool())
  
  in blur given blur now supports both translation and scaling. 
  I think we can kill that (leaving the mask check for coverswitch) and then remove all the force stuff from this effect.
  
  Does that make sense?

INLINE COMMENTS

> slide.cpp:394
> +    for (EffectWindow *w : windows) {
>          w->setData(WindowForceBackgroundContrastRole, QVariant());
> +        w->setData(WindowForceBlurRole, QVariant());

Do we need to call this from the dtor in case the effect is unloaded whilst we're active?

Not implausible if the user closes the "do you want to apply settings" prompt in kwin system settings.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15707

To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart