D15707: [effects/slide] Simplify logic that forces blur and background contrast

zzag added a comment.


  In D15707#333161 <https://phabricator.kde.org/D15707#333161>, @davidedmundson wrote:
  
  > I don't understand why we still do
  >
  >   if ((scaled || (translated || (mask & PAINT_WINDOW_TRANSFORMED))) && !w->data(WindowForceBlurRole).toBool())
  >   
  >
  > in blur given blur now supports both translation and scaling. 
  >  I think we can kill that (leaving the mask check for coverswitch) and then remove all the force stuff from this effect.
  >
  > Does that make sense?
  
  
  I agree, but I think we still need "force" roles. (to support third party full screen effects)

INLINE COMMENTS

> davidedmundson wrote in slide.cpp:394
> Do we need to call this from the dtor in case the effect is unloaded whilst we're active?
> 
> Not implausible if the user closes the "do you want to apply settings" prompt in kwin system settings.

Hmm, yeah, maybe.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15707

To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart