D15735: [effects/wobblywindows] Optimize wobbly windows effect
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added inline comments. INLINE COMMENTS > anthonyfieroni wrote in wobblywindows.cpp:358-373 > This is outlast pedantic, since it's duplicate code. Then name it like this: removal of duplicated code. If your patch is not only about removing duplicated code, mention the other "optimizations"/changes you did as well in the commit message. Or this will give you an indication that it might be better to directly split the patch up into multiple diffs, each improving one distinct aspect. The problem is that "optimization" can mean anything and everybody here seems to understand something differently by it. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D15735 To: anthonyfieroni, #kwin, zzag Cc: romangg, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart