D15949: [effects/zoom] Set wrap mode for cursor texture
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY With the Oxygen cursor theme, a visual glitch can appear in the bottom-left corner of the cursor when the screen is zoomed in. The reason for that is we're using GL_REPEAT for GL_TEXTURE_WRAP_S and GL_TEXTURE_WRAP_T. So, when the linear filter samples neighboring texels in the bottom, it can sample some texels from the top (because of GL_REPEAT). To fix that, we have to set the wrap mode to GL_CLAMP_TO_EDGE. BUG: 338254 FIXED-IN: 5.14.0 TEST PLAN Before: F6303912: Screenshot_20181004_202025.png <https://phabricator.kde.org/F6303912> After: F6303913: Screenshot_20181004_201911.png <https://phabricator.kde.org/F6303913> Tried other cursor themes(Breeze and Adwaita), everything looks okay. REPOSITORY R108 KWin BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D15949 AFFECTED FILES effects/zoom/zoom.cpp To: zzag, #kwin Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart