D15720: [TabBox] Fix Arrow Key / Keyboard Events in QML Alt+Tab Skins

Zren added a subscriber: mart.
Zren added a comment.


  I need to try patching plasma-framework's `dialog.cpp` and see if that introduces issues. Right now it's `mainItem->setParentItem(contentItem());`, and I need to test if `mainItem->setParent(contentItem());` breaks anything. I haven't patched C++ in frameworks before so I'll need to figure that out.
  
  https://github.com/KDE/plasma-framework/blob/master/src/plasmaquick/dialog.cpp#L797
  
  If I look at the git blame of that line, the last commit that touched `setParentItem` shows that there used to be a `d->mainItem->setParent(parent());`
  
  https://github.com/KDE/plasma-framework/commit/afe0524fa7371fe8e3f83010fd3fc06b6f9adc77#diff-af30a0e9bd2695def291bffd8524c589R636
  
  Hmmm, it looks like `setParent` was removed in this commit.
  
  https://github.com/KDE/plasma-framework/commit/ad03d0bb145736f26b8782f1229014172512084e
  
  @mart: Should I add main `mainItem->setParent(contentItem());`, or should we fix this in KWin?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15720

To: Zren, #kwin
Cc: mart, ngraham, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol