D16055: Send requested size in all configure events
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. davidedmundson requested review of this revision. REVISION SUMMARY Previously when updating the state we would send a configure event with the size 0,0. This means the client chooses the size. For regular window this works as most toolkits treat this to mean the size that we previously requested. It's not explicit in the spec either way. For maximised windows it's a problem, the spec clearly states that when maximised clients must follow the size given. Telling the client to be 0,0 doesn't make sense. By always sending our last requested size we remove any ambiguity. TEST PLAN Ran Maximised some windows and changed focus WAYLAND_DEBUG showed we weren't sending a configure with 0,0 after startup REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D16055 AFFECTED FILES shell_client.cpp shell_client.h To: davidedmundson, #kwin Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart