D14919: [effects/dialogparent] Fix flickering of parent windows
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added inline comments.
INLINE COMMENTS
> zzag wrote in kwinanimationeffect.cpp:291
> Yes, we should unref window. I was thinking about implementing something similar to FullScreenEffectLock, e.g.
>
> class KeepAliveLock
> {
> public:
> KeepAliveLock(EffectWindow *w) { w->refWindow(); }
> ~KeepAliveLock() { w->unrefWindow(); }
> ...
> };
Should allow us to remove m_zombies, that'll clean things up. Lets do it.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D14919
To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart