D16055: Send requested size in all configure events
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in shell_client.cpp:221 > Shouldn't we initialize m_requestedClientSize here? (just out of curiosity) I don't see a reason to. It's a protocol error to send a buffer before receiving a configure request so XdgShell code will never be in this path anyway. But also if we haven't explicitly requested a size, there's no reason not to continue letting the client keep picking the size. Mixing requested and current state is where we open ourselves to races that I want to avoid. I should technically unset in unmap though . REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D16055 To: davidedmundson, #kwin Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart