D16075: [libkwineffects] Don't expose the fullscreen effect lock to the public API

Vlad Zagorodniy <[email protected]> Tue, 9 Oct 2018 17:31:25 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag added a comment.


  In D16075#340145 <https://phabricator.kde.org/D16075#340145>, @davidedmundson wrote:
  
  > FWIW, it was a conscious decision to make it public (we should probably remove the d-pointer now it's private). There's nothing implementation detail of AnimationEffect about it, it'd work fine in any effect.
  
  
  I'll delete the d-pointer. Do I have to request a review for such a small change?
  
  > But meh, it was kinda in the wrong place if I did want to do that and it's not as useful with the way one typically writes C++ effects.
  
  +

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16075

To: zzag, #kwin, davidedmundson
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart