D16101: [activities] Fix logic error in user menu blocking activity updates

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  There's an attempt to block updates to activities whilst the popup menu
  is showing.
  
  In one of the two code paths for positioning the menu the block is set
  but instead of releasing the block at the end of the exec locks it
  again.
  
  CCBUG: 335725

TEST PLAN
  On X11 changed activities with the popup menu near the bottom.
  It still flickered like crazy whilst the menu is open (see bug report)
  But now at least fixes itself after

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16101

AFFECTED FILES
  useractions.cpp

To: davidedmundson, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart