D16216: [effects/diminactive] Add option to exclude fullscreen windows from dimming
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added reviewers: KWin, Plasma. Herald added a project: KWin. Herald added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY Such an option would be useful for people that are used to watch videos in the fullscreen mode. By default, we still dim fullscreen windows because watching videos in fullscreen mode is not the only one use-case. One could have a text editor in fullscreen mode on one screen and Konsole on another screen. In that case, it would be desired to dim the text editor if the latter is active. Also, because we don't have stats of how the fullscreen mode is used by KDE Plasma users. BUG: 399822 FIXED-IN: 5.15.0 TEST PLAN - Unchecked the "Fullscreen windows" checkbox; - Opened Konsole; - Opened Firefox in the fullscreen mode; - Pressed Alt+Tab; - (Firefox stayed bright) REPOSITORY R108 KWin BRANCH effects-diminactive-dont-dim-fullscreen REVISION DETAIL https://phabricator.kde.org/D16216 AFFECTED FILES effects/diminactive/diminactive.cpp effects/diminactive/diminactive.h effects/diminactive/diminactive.kcfg effects/diminactive/diminactive_config.ui To: zzag, #kwin, #plasma Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart