D16232: Always keep group transients above

zzag created this revision.
zzag added reviewers: KWin, Plasma.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  The original intent behind not keeping non-modal dialog group transients
  was to let the search window in KMail go behind the main window. See bug 76026.
  
  But the proposed solution has some problems:
  
  - first, we're working around "bugs" in KMail. The search window should not be a transient if one wants to put it behind the main window;
  - we're not following the EWMH spec: "Windows that are transient for another window should be kept above this window."
  
  Even though the spec doesn't explicitly mention group transients, I
  think that statement applies to them too.

TEST PLAN
  - Opened KMail;
  - Pressed the "S" key on my keyboard;
  - Clicked on an empty area in the main window;
  - (the search window didn't go behind the main window)

REPOSITORY
  R108 KWin

BRANCH
  always-keep-group-transients-above

REVISION DETAIL
  https://phabricator.kde.org/D16232

AFFECTED FILES
  autotests/integration/stacking_order_test.cpp
  layers.cpp

To: zzag, #kwin, #plasma
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart