D16325: [wayland] XdgPopup Positioning

David Edmundson <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Support XDGShell Positioning. This gives a client a lot more control
  over where the popup will be placed as well as control over how to
  handle constraints. i.e what to do if the popup doesn't fit.
  
  trasientOffset was replaced with a method on the client as semantically
  it's the role of the client to handle constraints.
  
  Both slide and flip constraint adjustments are implemented. Resize
  constraint adjustment will be handled in a future patch.
  
  WlShell is handled by treating it as 1x1 sized anchor with slide
  constraint adjustment.

TEST PLAN
  Manual test of a client implementing xdgpopup exists in kwayland
  Extensive unit test here
  
  Existing WlShell test passes (after D16314 <https://phabricator.kde.org/D16314> which fixes the original)
  XdgPopup has a new unit test suite against manually calculated values

REPOSITORY
  R108 KWin

BRANCH
  xdg_popup

REVISION DETAIL
  https://phabricator.kde.org/D16325

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  autotests/integration/kwin_wayland_test.h
  autotests/integration/test_helpers.cpp
  autotests/integration/transient_no_input_test.cpp
  autotests/integration/transient_placement.cpp
  placement.cpp
  shell_client.cpp
  shell_client.h

To: davidedmundson, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.