D16278: [effects/presentwindows] Avoid potential freeze during fill-gaps
Erik Kurzinger <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
ekurzinger added a comment. In D16278#346177 <https://phabricator.kde.org/D16278#346177>, @graesslin wrote: > In D16278#345365 <https://phabricator.kde.org/D16278#345365>, @zzag wrote: > > > > The freeze is still intermittent, but using this method should be able to be triggered within about 10 tries without this fix. > > > > Well, I wasted hours trying to reproduce the bug with no luck. > > > So did I! Good job. Yeah, sorry about that, guys. It took me quite a while to get a repro setup as well. I guess it's just really, really finicky. There seem to be a fair number of users on the bug tracker experiencing the issue, though. Perhaps it will be worth checking with them after this is merged to verify that it does indeed fix things? In D16278#346210 <https://phabricator.kde.org/D16278#346210>, @zzag wrote: > Recomputing `heightDiff` after each enlargement is sensible, so I think this is good to go. > > @ekurzinger Do you have commit access? If not, can you please provide your real name and email for commit authorship information? I do not. My full name is Erik Kurzinger and my email is [email protected] Also, I've removed that last superfluous re-computation - thanks for catching that, Vlad! REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D16278 To: ekurzinger, #kwin, zzag Cc: graesslin, kwin, zzag, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart