D16325: [wayland] XdgPopup Positioning
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson marked 11 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in shell_client.cpp:1622 > ... or Q_ASSERT_X to print more "user"-friendly message. This is the one of the few times where Q_UNREACHABLE actually saves a single jump instruction. May as well, given it documents the assert better. > zzag wrote in shell_client.h:213 > We probably don't need const for anchor edges and gravity. Sure I don't need them from the view of whoever is calling this method, I'm making a copy and functionally equivalent but I want to document them as being local within the body of the method. REPOSITORY R108 KWin BRANCH xdg_popup REVISION DETAIL https://phabricator.kde.org/D16325 To: davidedmundson, #kwin, graesslin Cc: zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart