D13887: use the new plasma virtual desktop protocol

davidedmundson added a comment.


  One minor comment left, then I think we should ship this.

INLINE COMMENTS

> abstract_client.cpp:563
> +{
> +    VirtualDesktop *virtualDesktop = VirtualDesktopManager::self()->desktopForX11Id(desktop);
> +

set Desktop had a range check so there was a guard.

This has not guard that desktop is in bounds. Given it's invoked from effects, we should.

> abstract_client.cpp:570
> +    }
> +
> +    windowManagementInterface()->removePlasmaVirtualDesktop(virtualDesktop->id());

The add code  has

if (m_desktops.isEmpty()) {
 windowManagementInterface()->setOnAllDesktops(true);
}

this does not.

Either the windowManagementInterface should be responsible for it in both add and remove, or kwin should in both add and remove.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D13887

To: mart, #plasma, #kwin, graesslin, davidedmundson
Cc: hein, zzag, davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart