D15020: [xwl] Move Xwayland parts into separate class
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in xwayland.cpp:236-237 > This isn't really within the scope of an XWayland class as it's handling startup, stuff app should be doing. > > More correct to emit something and have it handled with the same ApplicationWayland::continueStartupWithSceen True, the function is just copy and paste from `ApplicationWayland::continueStartupWithX`. I would like to leave it as is and do this later. Best would be if we could omit all calls on `m_app` here. > davidedmundson wrote in xwayland.cpp:241 > This isn't needed on wayland, ksplash is changed to ignore "wm" startup signals Just copy and paste from old code. If it is unneeded even better. But I would like to put the removal in a separate patch then. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D15020 To: romangg, #kwin, davidedmundson Cc: davidedmundson, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart