D15020: [xwl] Move Xwayland parts into separate class
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in xwayland.cpp:236-237 > > I would like to leave it as is and do this later. > > It'll take like 5 minutes, and is within the scope of splitting out xwayland into a separate class. > I don't see a reason to do it later. As said, it is noted and shall be dealt with later. I'm tired of arguing about such superficial stuff. If there is a functional defect with a patch I'm posting, I'm happy for every comment pointing it out and will change the diff of course, but if it's just about minor code cosmetics / structure let's try to avoid wasting time or worse, changing the diff on the fly for the sake of it and in the end risking a regression in a complex patch series. There are real functional changes in the other patches of this series, which are of more importance to be studied thoroughly than the one we are arguing about right now. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D15020 To: romangg, #kwin, davidedmundson Cc: davidedmundson, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart