D15061: [xwl] Generic X selections translation mechanism with Clipboard support

zzag added inline comments.

INLINE COMMENTS

> selection_source.h:33-34
> +
> +namespace KWayland {
> +namespace Client {
> +class DataSource;

Please follow coding style.

> selection_source.h:52
> + */
> +class SelSource : public QObject
> +{

The filename is selection_source.h, so it makes sense to use the full name (SelectionSource).

> selection_source.h:135
> +Q_SIGNALS:
> +    void offersChanged(QVector<QString> added, QVector<QString> removed);
> +    void transferReady(xcb_atom_t target, qint32 fd);

Could you please explain why you use QVector<QString> instead of QStringList?

REVISION DETAIL
  https://phabricator.kde.org/D15061

To: romangg, #kwin
Cc: zzag, graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart