D16432: Use consistent size icon in OSD

David Edmundson <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The OSD's icon is based on the implicitSize of the IconItem.
  
  For most icons this will be a hardcoded value from
  KIconLoader::global()->currentSize
  
  However, since bc33f0470d4d6bcbf30475f85b36705e8a99528b <https://phabricator.kde.org/R242:bc33f0470d4d6bcbf30475f85b36705e8a99528b> in
  plasma-framework we sometimes return that value, sometimes will return the
  source size of the underlying image depending on internal paths of how
  the icon is loaded and whether it was in the plasma theme or not.
  
  This patch overrides the implicitWidth given to the layout to be the
  standard icon size.
  
  BUG: 400083

TEST PLAN
  Loaded the force kill window OSD.
  Icon still looked the same size on breeze.
  
  I didn't reproduce the issue in the bug

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16432

AFFECTED FILES
  qml/onscreennotification/plasma/main.qml

To: davidedmundson, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.