D16391: [libkwineffects] Gracefully release previous window pixmap
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in kwinanimationeffect.cpp:350 > This line ends up missing. > > It doesn't look to make sense, but it was added explicitly: > b92ebe02aa49c162518b0a6ebd2481d79a1d3843 <https://phabricator.kde.org/R108:b92ebe02aa49c162518b0a6ebd2481d79a1d3843> I saw that commit and review on reviewboard, but... when exactly those glitches happen? If I maximize a translucent Konsole window, I don't see glitches. We can add repaint in the destructor of the lock, but then we need to document why that repaint is needed. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D16391 To: zzag, #kwin Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart