D16428: Support enabling numlock on startup

davidedmundson added inline comments.

INLINE COMMENTS

> xkb.cpp:259
> +        // STATE_ON = 0,  STATE_OFF = 1, STATE_UNCHANGED = 2, see plasma-desktop/kcms/keyboard/kcmmisc.h
> +        const auto setting = config.readEntry("NumLock", 2);
> +        const bool numLockIsOn = xkb_state_mod_index_is_active(m_state, m_numModifier, XKB_STATE_MODS_LOCKED);

The documentation in the UI says this will be "on plasma startup"

This code seems to set it whenever there's a reconfigure, which is subtly different.

I don't mess with keyboards enough to be able to say whether this is a good feature or a change that will be annoying.

REPOSITORY
  R108 KWin

BRANCH
  numlock-support

REVISION DETAIL
  https://phabricator.kde.org/D16428

To: graesslin, stikonas
Cc: davidedmundson, stikonas, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart