D16428: Support enabling numlock on startup
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in xkb.cpp:259 > The documentation in the UI says this will be "on plasma startup" > > This code seems to set it whenever there's a reconfigure, which is subtly different. > > I don't mess with keyboards enough to be able to say whether this is a good feature or a change that will be annoying. > I don't mess with keyboards enough to be able to say whether this is a good feature or a change that will be annoying. Me neither. I was aware of the difference. My first code for this was also with a tracker whether it's first run or not. I didn't really like the code and it would have required some nasty env variables to make it testable. In the end I decided against it as only a reconfigure from the kcm can trigger this code path. Given that I thought it was acceptable that it turns the num lock on. I would vote for if we get bug reports for it we do the ugly code. REPOSITORY R108 KWin BRANCH numlock-support REVISION DETAIL https://phabricator.kde.org/D16428 To: graesslin, stikonas Cc: davidedmundson, stikonas, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart