D13153: WIP: [libkwineffects] Allow effects to grab windows

zzag updated this revision to Diff 44344.
zzag added a comment.
This revision is now accepted and ready to land.


  - Add tests;
  - Use force flag only in grab(): Allow effects to steal window grabs, but only the owner of window grab can ungrab the window. The reason for that is scripted effects won't notice that they are no longer hold window grab because of how isGrabbed works, so instead one has to "steal" window grab and then call ungrab().

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13153?vs=35359&id=44344

REVISION DETAIL
  https://phabricator.kde.org/D13153

AFFECTED FILES
  autotests/integration/effects/scripted_effects_test.cpp
  autotests/integration/effects/scripts/grabAlreadyGrabbedWindowForcedTest_owner.js
  autotests/integration/effects/scripts/grabAlreadyGrabbedWindowForcedTest_thief.js
  autotests/integration/effects/scripts/grabAlreadyGrabbedWindowTest_grabber.js
  autotests/integration/effects/scripts/grabAlreadyGrabbedWindowTest_owner.js
  autotests/integration/effects/scripts/grabTest.js
  autotests/integration/effects/scripts/ungrabTest.js
  scripting/scriptedeffect.cpp
  scripting/scriptedeffect.h

To: zzag, #kwin, davidedmundson
Cc: romangg, graesslin, davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart